Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: introduce flat plan #35994

Merged
merged 7 commits into from
Jul 9, 2022
Merged

planner: introduce flat plan #35994

merged 7 commits into from
Jul 9, 2022

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: ref #35888 ref #35889

What is changed and how it works?

  • Introduce the flat plan.
  • Use the flat plan to implement EXPLAIN logic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2b2fcd05a6b7eb620b9eb8f9eed4e2814bc8eefc

AilinKid
AilinKid reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the explain result correctness has been guarded by old explainTestCase, so basically LGTM, sure it passed tidb-test too before it merged

planner/core/flat_plan.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2022
@time-and-fate
Copy link
Member Author

/run-unit-test

winoros
winoros approved these changes Jul 8, 2022
View reviewed changes
planner/core/flat_plan.go Outdated
// For physical operators, we just enumerate their children and collect their information.
// Note that some physical operators are special, and they are handled below this part.
if physPlan, ok := p.(PhysicalPlan); ok {
driverSideInfo := make([]OperatorLabel, len(physPlan.Children()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the driverSideInfo is old name

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b2fcd0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2022
@time-and-fate
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 28bf364 into pingcap:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@time-and-fate @ti-chi-bot @sre-bot @winoros @AilinKid