-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix incorrect runtime stats when there are apply
s
#35919
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1111016642d249d07b8927d044dba0ffab0b9764 |
/merge |
/run-mysql-test |
/run-check_dev_2 |
3 similar comments
/run-check_dev_2 |
/run-check_dev_2 |
/run-check_dev_2 |
/run-build |
/merge cancel |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1111016
|
/run-check_dev_2 |
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: close #35911 ref #35889
Problem Summary: please see #35911 for the incorrect behavior.
concurrency
of runtime stats ofIndexLookUp
andIndexMerge
is aggregated in theMerge()
method. This is different from other operators.Apply
, an executor may be reused (beOpen()
ed andClose()
ed multiple times), so the runtime stats for display should be the aggregated sum of them.But for
HashAgg
,IndexLookUp
, andIndexMerge
, we incorrectly aggregated two times, which makes the numbers in the runtime stats larger than the correct ones:What is changed and how it works?
concurrency
in theMerge()
method.HashAgg
,IndexLookUp
, andIndexMerge
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.