Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: introduce new cost formula for MPPAggs #35436

Merged
merged 7 commits into from
Jun 21, 2022
Merged

planner: introduce new cost formula for MPPAggs #35436

merged 7 commits into from
Jun 21, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35240

Problem Summary: introduce new cost formula for MPPAggs

What is changed and how it works?

On modelVer2: Hash/StreamAgg: use the dedicated TiFlash CPU Factor when calculating CPU costs;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jun 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7988c1245e8b2b9da82e05712302febbe2cedc68

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2022

wait for #35438

qw4990
qw4990 commented Jun 17, 2022
View reviewed changes
planner/core/plan_cost.go
@@ -1144,6 +1164,9 @@ func (p *PhysicalExchangeReceiver) GetPlanCost(taskType property.TaskType, costF
}

func getOperatorActRows(operator PhysicalPlan) float64 {
if operator == nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be nil in some update-statements.

@qw4990 qw4990 changed the title planner: introduce new cost formula for MPPAggs/MPPExchanger planner: introduce new cost formula for MPPAggs Jun 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
Reminiscent
Reminiscent reviewed Jun 21, 2022
View reviewed changes
planner/core/plan_cost.go
@@ -326,7 +331,8 @@ func (p *PhysicalTableReader) GetPlanCost(taskType property.TaskType, costFlag u
// consider concurrency
p.planCost /= concurrency
// consider tidb_enforce_mpp
if isMPP && p.ctx.GetSessionVars().IsMPPEnforced() {
if isMPP && p.ctx.GetSessionVars().IsMPPEnforced() &&
!hasCostFlag(costFlag, CostFlagRecalculate) { // show the real cost in explain-statements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this make a different plan when we use explain or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think it's expected. Currently, if we enable enforce_mpp, all plan costs will be zero, which is weird.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7988c12

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@ti-chi-bot ti-chi-bot merged commit 97ac647 into pingcap:master Jun 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 21, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 19 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 45 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 57 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jun 21, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into add-bootstrap-sql
d5c463f 
* upstream/master:
  planner: make some `show stmt` more fine-grained privilege check (pingcap#35493)
  session: improve bootstrap code (pingcap#34755)
  *: upgrade go-proxyprotocol version (pingcap#35560)
  planner: introduce new cost formula for MPPAggs (pingcap#35436)
qw4990 added a commit to qw4990/tidb that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce new cost formula for MPPAggs (pingcap#35436)
1a876c9 
ref pingcap#35240
@qw4990 qw4990 mentioned this pull request Jul 12, 2022
Merged
qw4990 added a commit that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce new cost formula for MPPAggs (#35436) (#36133)
a65753d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-chi-bot @sre-bot @Reminiscent @time-and-fate