-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br-stream: add precheck before create task #33088
br-stream: add precheck before create task #33088
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
rest LGTM |
(https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check/detail/tidb_ghpr_check/54908/pipeline#step-73-log-213)[2022-03-15T09:58:01.697Z] br/pkg/task/stream.go:22: File is not [2022-03-15T09:58:01.697Z] "github.com/pingcap/kvproto/pkg/metapb" [2022-03-15T09:58:01.697Z] "github.com/pingcap/tidb/br/pkg/httputil" [2022-03-15T09:58:01.697Z] br/pkg/task/stream_test.go:19: File is not [2022-03-15T09:58:01.697Z] "fmt" [2022-03-15T09:58:01.697Z] br/pkg/task/stream.go:359:28: response body must be closed (bodyclose) [2022-03-15T09:58:01.697Z] resp, e := s.httpCli.Get(addr) [2022-03-15T09:58:01.697Z] ^ [2022-03-15T09:58:01.697Z] level=info msg="File cache stats: 1702 entries of total size 26.3MiB" [2022-03-15T09:58:01.697Z] level=info msg="Memory: 2299 samples, avg is 1943.3MB, max is 10864.1MB" [2022-03-15T09:58:01.697Z] level=info msg="Execution took 4m7.969458773s" [2022-03-15T09:58:01.697Z] make: *** [check-static] Error 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add switch check before stream starts
What problem does this PR solve?
Issue Number: close #33087
Problem Summary:
make sure that all stores support log backup then create log backup tasks.
What is changed and how it works?
Check List
Tests
Release note