Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: handle contants in Selectivity() #32761

Merged
merged 7 commits into from
Mar 6, 2022
Merged

statistics: handle contants in Selectivity() #32761

merged 7 commits into from
Mar 6, 2022

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Mar 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32835 ref #32758

Problem Summary: Please see the issue and test cases for detail.

What is changed and how it works?

Handle contants in Selectivity().

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/81733e7387746600701ef1423da66c855e037f92

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2022
time-and-fate
time-and-fate commented Mar 4, 2022
View reviewed changes
cmd/explaintest/r/explain_easy.result
Comment on lines +509 to +519
└─HashAgg 1.00 root group by:Column#32, Column#33, Column#34, funcs:count(1)->Column#31
└─Projection 0.01 root Column#14, Column#15, coalesce(test.test02.region_name, 不详)->Column#34
└─IndexJoin 0.01 root left outer join, inner:TableReader, outer key:Column#16, inner key:test.test02.id, equal cond:eq(Column#16, test.test02.id)
├─Union(Build) 0.01 root
│ ├─TableDual 0.00 root rows:0
│ └─Projection 0.01 root test.test01.stat_date, test.test01.show_date, test.test01.region_id
│ └─TableReader 0.01 root data:Selection
│ └─Selection 0.01 cop[tikv] eq(test.test01.period, 1), ge(test.test01.stat_date, 20191202), gt(cast(test.test01.registration_num, bigint(20) BINARY), 0), le(test.test01.stat_date, 20191202)
│ └─TableFullScan 10000.00 cop[tikv] table:test01 keep order:false, stats:pseudo
└─TableReader(Probe) 1.00 root data:TableRangeScan
└─TableRangeScan 1.00 cop[tikv] table:b range: decided by [Column#16], keep order:false, stats:pseudo
Copy link
Member Author

@time-and-fate time-and-fate Mar 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change essentially reverts the changes in #21061.
Detail: https://github.com/pingcap/tidb/pull/21061/files#diff-b2102aac708eea9196b2b098c7484d1e70e76b864e2eaa28978a231419fe6a55.
I think it's expected and acceptable.
And because test cases here don't load real stats, this change doesn't make much sense.

time-and-fate
time-and-fate commented Mar 4, 2022
View reviewed changes
cmd/explaintest/r/imdbload.result
@@ -279,6 +279,15 @@ id estRows task access object operator info
TableReader_7 804024.75 root data:Selection_6
└─Selection_6 804024.75 cop[tikv] or(and(eq(imdbload.char_name.imdb_index, "I"), lt(imdbload.char_name.surname_pcode, "E436")), and(eq(imdbload.char_name.imdb_index, "L"), lt(imdbload.char_name.surname_pcode, "E436")))
└─TableFullScan_5 4314864.00 cop[tikv] table:char_name keep order:false
explain select * from char_name use index (itest2) where ((imdb_index = 'I') and (surname_pcode < 'E436')) or ((imdb_index = 'L') and (surname_pcode < 'E436'));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are irrelevant to this PR. My next PR will need these test results for comparison.

@time-and-fate time-and-fate mentioned this pull request Mar 4, 2022
Closed
12 tasks
AilinKid
AilinKid approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2022
@AilinKid
Copy link
Contributor

AilinKid commented Mar 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 11ce2c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2022
@ti-chi-bot
Copy link
Member

@time-and-fate: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7cf784c into pingcap:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable Selectivity() to handle constants
5 participants
@time-and-fate @ti-chi-bot @sre-bot @AilinKid @qw4990