Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add LEARNERS row to information_schema.placement_policies in design doc #31700

Merged
merged 10 commits into from
Jan 17, 2022
Merged

*: Add LEARNERS row to information_schema.placement_policies in design doc #31700

merged 10 commits into from
Jan 17, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jan 14, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #18030

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2022
@lcwangchao lcwangchao changed the title *: Update 2020-06-24-placement-rules-in-sql.md *: Add LEARNERS row to information_schema.placement_policies in design doc Jan 14, 2022
@lcwangchao lcwangchao requested a review from morgo January 14, 2022 10:13
@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d98180723bb5105beb0d82306b5e177bd90d5a7c

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f4fcaa1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 6db56bb into master Jan 17, 2022
@ti-chi-bot ti-chi-bot deleted the lcwangchao-patch-1 branch January 17, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcwangchao @ti-chi-bot @sre-bot @hawkingrei @morgo