executor: Fix a panic when using on duplicate update (#31287)

[ti-srebot]

cherry-pick #31287 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/31345

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/31345:release-5.4-42e009a53873

---

What problem does this PR solve?

Issue Number: close #28078

Problem Summary: When using statements like insert into a select ... from b on duplicate key update a.y = b.y, where b.y is not selected in select ... from b part, sometimes it may panic and reports "slice bounds out of range".

initEvalBuffer4Dup constructs a list of column types (the evalBufferTypes variable), which is expected to match the Schema4OnDuplicate built in function Schema4OnDuplicate. It contains several parts sequentially:

• columns of already-existed rows
• extra columns to select (the implicitly required columns in the on duplicate key update clause)
• columns of new rows to insert

The problem is:

1. When constructing evalBufferTypes, wrong index is used to find the second part (extra columns to select) . The inner select plan contains both explicitly written columns in select clause (which are columns [:actualColLen]), and the implicitly required columns in the on duplicate key update clause (which are columns [actualColLen:]). In function initEvalBuffer4Dup, the actualColLen is exactly e.rowLen.
2. Then it creates a buffer for storing values to be inserted. It's expected to match the third part of evalBufferTypes mentioned above. However wrong index is used again and it didn't count the number of extra columns to the offset.

What is changed and how it works?

Fixed the above two mistakes.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix a panic that may happen when using `on duplicate key update`.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cfzjywxk
• winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-srebot]

@MyonKeminta you're already a collaborator in bot's repo.

[VelocityLight]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 36ca5d5

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.