Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix panic when the join key is scalarFunction (#30002) #30777

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 16, 2021

cherry-pick #30002 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30777

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30777:release-5.3-05ccb8a206da

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: close #29401

Problem Summary:

If one side of the join key is string, and the another is json, the expression of the string would be cast to json and marked ParseToJSONFlag which will let WrapWithCastAsJSON wrap extra cast function.

In order to avoid this problem, we remove ParseToJSONFlag temporary during updateEQCond.

The final explain info result for the original issue is like following:

mysql> explain select /*+ inl_hash_join(t1) */ * from t t1 join t t2 on t1.b=t2.e;
+-----------------------------+----------+-----------+---------------+---------------------------------------------------------------------------------------------------------------+
| id                          | estRows  | task      | access object | operator info                                                                                                 |
+-----------------------------+----------+-----------+---------------+---------------------------------------------------------------------------------------------------------------+
| HashJoin_8                  | 12500.00 | root      |               | inner join, equal:[eq(Column#15, test.t.e)]                                                                   |
| ├─TableReader_14(Build)     | 10000.00 | root      |               | data:TableFullScan_13                                                                                         |
| │ └─TableFullScan_13        | 10000.00 | cop[tikv] | table:t2      | keep order:false, stats:pseudo                                                                                |
| └─Projection_10(Probe)      | 10000.00 | root      |               | test.t.id, test.t.a, test.t.b, test.t.c, test.t.d, test.t.e, test.t.f, cast(test.t.b, json BINARY)->Column#15 |
|   └─TableReader_12          | 10000.00 | root      |               | data:TableFullScan_11                                                                                         |
|     └─TableFullScan_11      | 10000.00 | cop[tikv] | table:t1      | keep order:false, stats:pseudo                                                                                |
+-----------------------------+----------+-----------+---------------+---------------------------------------------------------------------------------------------------------------+
6 rows in set, 1 warning (0.00 sec)

What is changed and how it works?

This request fixs this case.

Check List

Tests

  • Unit test

Release note

Fix the bug that sql got cancel if including json column joins char column.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 16, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 16, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick type/bugfix This PR fixes a bug. labels Dec 16, 2021
@ti-srebot
Copy link
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

@Yisaer please remember to merge this pr. A new version is about to release. Thanks!

/run-check_dev
/run-mysql-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Apr 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 70d2e65

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Apr 12, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022

@ti-chi-bot ti-chi-bot merged commit b8fbab3 into pingcap:release-5.3 Apr 12, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants