Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: Add source dir existence check for s3 #30674

Merged
merged 9 commits into from
Dec 14, 2021
Merged

lightning: Add source dir existence check for s3 #30674

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5132257
add subdir check
glorv Dec 14, 2021
5b39d56
fix
glorv Dec 14, 2021
7e30299
fix typo
glorv Dec 14, 2021
6cb3cb7
fix
glorv Dec 14, 2021
2a7ff62
remove skip-check-path parameter
glorv Dec 14, 2021
87e1c06
Merge branch 'master' into check-dir
glorv Dec 14, 2021
556b770
fix test
glorv Dec 14, 2021
569747a
Merge branch 'check-dir' of ssh://github.com/glorv/tidb into check-dir
glorv Dec 14, 2021
3894f3c
Merge branch 'master' into check-dir
glorv Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
@glorv
glorv committed Dec 14, 2021
commit 6cb3cb789377894ce44e5d16bb2b06293ff15fbd
2 changes: 1 addition & 1 deletion br/pkg/lightning/lightning.go
View file
Original file line number Diff line number Diff line change
@@ -306,7 +306,7 @@ func (l *Lightning) run(taskCtx context.Context, taskCfg *config.Config, g glue.
if walkErr == nil {
return errors.Errorf("data-source-dir '%s' doesn't exist or contains no files", taskCfg.Mydumper.SourceDir)
}
return errors.Annotatef(walkErr, "visit data-source-dir '%s' failed: ", taskCfg.Mydumper.SourceDir)
return errors.Annotatef(walkErr, "visit data-source-dir '%s' failed", taskCfg.Mydumper.SourceDir)
}

loadTask := log.L().Begin(zap.InfoLevel, "load data source")