Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: cherry-pick 27121 #29119

Merged
merged 4 commits into from
Aug 15, 2022
Merged

*: cherry-pick 27121 #29119

merged 4 commits into from
Aug 15, 2022

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Related to pingcap/parser#1363.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Recognize 'references' privilege and ignore it.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Oct 26, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@tangenta tangenta changed the title update parser dependency parser: update dependency Oct 26, 2021
@tangenta
Copy link
Contributor Author

/run-check_title

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2021
@dveeden
Copy link
Contributor

dveeden commented Dec 13, 2021

I assume this is no longer current now that pingcap/parser is merged into pingcap/tidb?

@tangenta
Copy link
Contributor Author

@dveeden In release v5.2 the parser repo is not merged.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

to #26703

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 12, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 796b298

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/hold

test is faling stably, need a second look

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2022
@xhebox xhebox changed the title parser: update dependency *: cherry-pick 27121 Aug 15, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 15, 2022

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ab7edc7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2022
@xhebox
*: fix CI
5ebc8bc 
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5ebc8bc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5ebc8bc851276524a10a70ffda21264c7b37471f

@ti-chi-bot ti-chi-bot merged commit aa97c67 into pingcap:release-5.2 Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@kennytm kennytm kennytm approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tangenta @ti-chi-bot @sre-bot @dveeden @xhebox @kennytm @VelocityLight