Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: refine placement options check #29050

Merged
merged 14 commits into from
Oct 26, 2021
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Oct 25, 2021

What problem does this PR solve?

Issue Number: close #28767 and #29006

Problem Summary: Fix checks to adapt the RFC requirement.

What is changed and how it works?

  1. We always prefer sugar sytax if possible
  2. For non-sugar options, it is allowed to set only one leader or some followers(voter). But it is not allowed to miss both options.
  3. For non-sugar options, forbid set XX_CONSTRAINTS without specifying counts.
  4. For sugar options, it is allowed to omit followers when *REGIONS are set, or the revert. But you can not omit all options.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2021
@xhebox xhebox requested review from morgo and lcwangchao October 25, 2021 02:46
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tidb> create table t1 (a int) followers=4;
Query OK, 0 rows affected (0.11 sec)

tidb> create placement policy `global` primary_region='us-central1' regions='us-central1,us-west1,asia-northeast1';
Query OK, 0 rows affected (0.08 sec)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2021
@morgo morgo requested a review from AilinKid October 25, 2021 03:04
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2021
Signed-off-by: xhe <[email protected]>
ddl/placement/bundle.go Show resolved Hide resolved
ddl/placement/bundle.go Outdated Show resolved Hide resolved
if len(options.PrimaryRegion) > 0 || len(options.Regions) > 0 || len(options.Schedule) > 0 {
isSyntaxSugar = true
// always prefer the sugar syntax, which gives better schedule results most of the time
isSyntaxSugar := true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the old implement and regard single followers=xx configuration as non-sugar options. It is easier to understand.

Copy link
Contributor Author

@xhebox xhebox Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is just the reverse. It is same. And I must admit sugar options, now, are really smarter than the non-sugar one. Only if you know what you are doing, can you make a better policy with non-sugar options.

BTW, followers are allowed in both options, and you can not use it to distinguish whether it is sugar or not.

@xhebox xhebox requested a review from lcwangchao October 26, 2021 02:16
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Oct 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 742da59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Oct 26, 2021

/merge

@ti-chi-bot
Copy link
Member

@xhebox: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit af811b6 into pingcap:master Oct 26, 2021
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhebox xhebox deleted the placement_3 branch January 11, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placement option of FOLLOWERS=4 not supported
5 participants