-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add placement policy name / direct placement to is.tables/partitions #28798
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some test cases.
/run-check_title |
I like it. Please add tests :-) |
Do we need to record it in the RFC? |
I will update it in another PR. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: eee83f7
|
@mjonss: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Related to #18030 and #26681.
Problem Summary:
Missing ways to get placement from tables and partitions in an easy way or machine readable.
I added two new columns to both information_schema.tables and information_schema.partitions:
TIDB_PLACEMENT_POLICY_NAME and TIDB_DIRECT_PLACEMENT, which are NULLable varchar.
TIDB_PLACEMENT_POLICY_NAME refers to the named placement policy, and can be expanded either with
SHOW PLACEMENT FOR POLICY <policy name>
or through information_schema.placement_rules (likeSELECT * FROM information_schema.tables t left join information_schema.placement_rules pr on t.TIDB_PLACEMENT_POLICY_NAME = pr.POLICY_NAME WHERE t.TABLE_NAME = 't'
What is changed and how it works?
What's Changed:
Two new columns in is.tables and is.partitions
Check List
Tests
Side effects
Documentation
Release note