Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add placement policy name / direct placement to is.tables/partitions #28798

Merged
merged 6 commits into from
Oct 18, 2021

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 13, 2021

What problem does this PR solve?

Related to #18030 and #26681.

Problem Summary:
Missing ways to get placement from tables and partitions in an easy way or machine readable.
I added two new columns to both information_schema.tables and information_schema.partitions:
TIDB_PLACEMENT_POLICY_NAME and TIDB_DIRECT_PLACEMENT, which are NULLable varchar.

TIDB_PLACEMENT_POLICY_NAME refers to the named placement policy, and can be expanded either with SHOW PLACEMENT FOR POLICY <policy name> or through information_schema.placement_rules (like SELECT * FROM information_schema.tables t left join information_schema.placement_rules pr on t.TIDB_PLACEMENT_POLICY_NAME = pr.POLICY_NAME WHERE t.TABLE_NAME = 't'

What is changed and how it works?

What's Changed:
Two new columns in is.tables and is.partitions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility - New columns in is.tables and is.partitions

Release note

Added TIDB_PLACEMENT_POLICY_NAME and TIDB_DIRECT_PLACEMENT columns to information_schema tables `tables` and `partitions`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@xhebox xhebox self-requested a review October 14, 2021 03:34
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases.

@morgo morgo changed the title add placement policy name / direct placement to is.tables/partitions executor: add placement policy name / direct placement to is.tables/partitions Oct 15, 2021
@morgo
Copy link
Contributor

morgo commented Oct 15, 2021

/run-check_title

@morgo
Copy link
Contributor

morgo commented Oct 15, 2021

I like it. Please add tests :-)

@xhebox
Copy link
Contributor

xhebox commented Oct 15, 2021

I like it. Please add tests :-)

Do we need to record it in the RFC?

@morgo
Copy link
Contributor

morgo commented Oct 15, 2021

Do we need to record it in the RFC?

I will update it in another PR.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2021
@morgo morgo self-requested a review October 18, 2021 15:13
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2021
@morgo
Copy link
Contributor

morgo commented Oct 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eee83f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2021
@ti-chi-bot
Copy link
Member

@mjonss: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 84ec663 into pingcap:master Oct 18, 2021
@mjonss mjonss deleted the is.tables-placement branch October 19, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants