Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: migrate test infra for br/pkg/logutil/loggin_test.go to testify #28557

Merged
merged 8 commits into from
Oct 8, 2021
Merged

Refactor: migrate test infra for br/pkg/logutil/loggin_test.go to testify #28557

merged 8 commits into from
Oct 8, 2021

Conversation

yuyawk
Copy link
Contributor

@yuyawk yuyawk commented Oct 7, 2021

What problem does this PR solve?

Issue Number: close #28171

Problem Summary:

What is changed and how it works?

What's Changed:

  • This PR migrates test infra for br/pkg/logutil/loggin_test.go to testify.

How it Works:

  • All tests passed.

Release note 

None

Remarks

I'm a newcomer to this repo. If I had anything inappropriate, it would be great if you point it out.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 7, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @yuyawk!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@yuyawk
Copy link
Contributor Author

yuyawk commented Oct 7, 2021

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun October 7, 2021 15:02
tisonkun
tisonkun requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @yuyawk ! Comments inline.

Please also check whether we can run these tests in parallel by t.Parallel().

br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
@yuyawk
Suggestions reflected:
fd48da3 
    * make t.Parallel() available
    * testify/assert -> testify/require
    * fix the order of the argments in require.(function name)
@yuyawk
Copy link
Contributor Author

yuyawk commented Oct 8, 2021 •
edited
Loading

Thanks for your contribution @yuyawk ! Comments inline.

Please also check whether we can run these tests in parallel by t.Parallel().

Thank you for your review. I've fixed them.
fd48da3

tisonkun
tisonkun approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For addressing comments, you can follow this doc for applying suggestions and resolving the comments.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Oct 8, 2021

/cc @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from YuJuncen October 8, 2021 03:18
YuJuncen
YuJuncen approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also please check the comment

br/pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@YuJuncen
Copy link
Contributor

YuJuncen commented Oct 8, 2021

/merge

thanks!

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: acf40b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot
Copy link
Member

@yuyawk: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d458059 into pingcap:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for br/pkg/logutil
6 participants
@yuyawk @ti-chi-bot @CLAassistant @tisonkun @YuJuncen @ti-srebot