Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/pkg/membuf: migrate test-infra to testify #28210

Merged
merged 1 commit into from
Sep 19, 2021
Merged

br/pkg/membuf: migrate test-infra to testify #28210

merged 1 commit into from
Sep 19, 2021

Conversation

shadw3002
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28172

Problem Summary: migrate test-infra to testify for br/pkg/membuf

What is changed and how it works?

What's Changed: migrate test-infra to testify for br/pkg/membuf

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 19, 2021
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 19, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2021
@shadw3002
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@shadw3002
Copy link
Contributor Author

/run-check_dev_2

@shadw3002
Copy link
Contributor Author

/cc @tisonkun
PTAL

@ti-chi-bot ti-chi-bot requested a review from tisonkun September 19, 2021 06:05
tisonkun
tisonkun approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2021
@tisonkun
Copy link
Contributor

/cc @lance6716

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2021
@lance6716
Copy link
Contributor

Thanks for your contribution, welcome to pick more issues 👍

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6e6208f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2021
@ti-chi-bot ti-chi-bot merged commit 2cf4a90 into pingcap:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for br/pkg/membuf
5 participants
@shadw3002 @ti-chi-bot @tisonkun @lance6716 @ti-srebot