-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain, executor: make flush privilege propagate via etcd #27958
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ab3ee5b
|
What problem does this PR solve?
Issue Number: close #14914
Problem Summary:
Flush Privileges did not call
NotifyUpdatePrivilege()
, so peer tidb-servers were not notified.What is changed and how it works?
What's Changed:
FLUSH PRIVILEGES
now propagates to other tidb servers.Check List
Tests
Because etcd notifications is not tested by the test-suite, I manually tested:
On server tidb-4000 I created a user u1
On server tidb-4001 I logged in as u1
On server tidb-4000 I manually edited mysql.user so u1 had higher privileges. I then executed FLUSH PRIVILEGES.
On server tidb-4001 I observed the changes were immediately visible.
No code
Side effects
Documentation
Release note