Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain, executor: make flush privilege propagate via etcd #27958

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Sep 10, 2021

What problem does this PR solve?

Issue Number: close #14914

Problem Summary:

Flush Privileges did not call NotifyUpdatePrivilege(), so peer tidb-servers were not notified.

What is changed and how it works?

What's Changed:

FLUSH PRIVILEGES now propagates to other tidb servers.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Because etcd notifications is not tested by the test-suite, I manually tested:

  • On server tidb-4000 I created a user u1

  • On server tidb-4001 I logged in as u1

  • On server tidb-4000 I manually edited mysql.user so u1 had higher privileges. I then executed FLUSH PRIVILEGES.

  • On server tidb-4001 I observed the changes were immediately visible.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

`FLUSH PRIVILEGES` now immediately propagates to other tidb-servers.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 10, 2021
@morgo morgo requested a review from tiancaiamao September 10, 2021 20:34
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2021
@morgo morgo requested a review from bb7133 September 10, 2021 20:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@morgo morgo requested review from a team and removed request for a team September 23, 2021 03:15
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ab3ee5b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It takes time to broadcast FLUSH PRIVILEGES to all TiDB instances
4 participants