Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Support ALTER DATABASE Placement Policy/ DirectOptions #27894

Merged
merged 50 commits into from
Oct 9, 2021
Merged

ddl: Support ALTER DATABASE Placement Policy/ DirectOptions #27894

merged 50 commits into from
Oct 9, 2021

Conversation

sylzd
Copy link
Contributor

@sylzd sylzd commented Sep 8, 2021 •
edited
Loading

What problem does this PR solve?

Fixes #27975

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Support ALTER DATABASE Placement Policy/ DirectOptions

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2021
@mjonss
Copy link
Contributor

mjonss commented Sep 12, 2021

Hi @sylzd , I missed that you were working on this. I started on #27969 which seems very related (but have not touched the ALTER part).

@sylzd
Copy link
Contributor Author

sylzd commented Sep 13, 2021 •
edited
Loading

Hi @sylzd , I missed that you were working on this. I started on #27969 which seems very related (but have not touched the ALTER part).

Nice work! I will close the pr, if you wanna any help, plz call me.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021
@sylzd sylzd changed the title wip: ddl: Support ALTER DATABASE DEFAULT PLACEMENT POLICY ddl: Support ALTER DATABASE Placement Policy/ DirectOptions Sep 28, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2021
@sylzd sylzd changed the title ddl: Support ALTER DATABASE Placement Policy/ DirectOptions wip:ddl: Support ALTER DATABASE Placement Policy/ DirectOptions Sep 28, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2021
AilinKid
AilinKid reviewed Oct 8, 2021
View reviewed changes
ddl/schema.go Outdated Show resolved Hide resolved
AilinKid
AilinKid reviewed Oct 8, 2021
View reviewed changes
ddl/schema.go Show resolved Hide resolved
AilinKid
AilinKid reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

AilinKid
AilinKid reviewed Oct 8, 2021
View reviewed changes
executor/show.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@AilinKid
Copy link
Contributor

AilinKid commented Oct 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37d68f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Oct 9, 2021

/run-check_dev_2

@AilinKid
Copy link
Contributor

AilinKid commented Oct 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3118810

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2021
@ti-chi-bot
Copy link
Member

@sylzd: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5924693 into pingcap:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@mjonss mjonss mjonss approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add placement rules for a schema via ALTER DATABASE
5 participants
@sylzd @ti-chi-bot @mjonss @AilinKid @morgo