Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Support
SHOW PLACEMENT
for placement policies #27531*: Support
SHOW PLACEMENT
for placement policies #27531Changes from 3 commits
f540835
5a40396
9b10874
2c9e1bf
50a6905
5c07053
949a539
061c0cd
035850d
6c34990
2834dd4
d2448cb
b70a76a
6987274
602f761
b231844
317d6cb
7ade5dd
1005546
2d23b1d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
policyMutex
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the current code, I found
AllPlacementPolicies
is not needed any more becausePlacementPolicies
did the same work. I'll remove this method and addPlacementPolicies
to the interface.But I think it is still safe without
policyMutex
because infoschema is immutable. The happens-before condition can be established for our current implementThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just there in case, IMO. You are right that sometimes we are too cautious to do some great works. But this case is a little bit aggressive for me, especially that other
policy
APIs are following the conract of the mutex.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Actually I did not see
policyMutex
and just follow what the functionAllSchemas
did. As other policy APIs usepolicyMutex
I think we should follow it either.