Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br, tidb: Add backup and restore size for TiDB SQL brie task #27508

Merged
merged 7 commits into from
Aug 25, 2021
Merged

br, tidb: Add backup and restore size for TiDB SQL brie task #27508

merged 7 commits into from
Aug 25, 2021

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Aug 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #27247

Problem Summary:
SQL backup and restore show a 0 size

What is changed and how it works?

SQL backup and restore shall show a correct size, not 0.
Proposal: xxx

What's Changed:
add backup size
How it Works:
glue is communitation class between tidb and br, glue does not record a size for general tidb sql.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

  1. on centos, using tiup to create cluster following by https://docs.pingcap.com/zh/tidb/stable/quick-start-with-tidb#使用-tiup-cluster-在单机上模拟生产环境部署步骤

  2. filled some data as issue described: BACKUP SQL Command returns size of 0 #27247

  3. exec sql backup and restore, then check the result

  4. create backup by command

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Please add a release note, or a 'None' if it is not needed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@fengou1 fengou1 changed the title Add backup and restore size for TiDB SQL brie task br, tidb: Add backup and restore size for TiDB SQL brie task Aug 23, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

run-check_title

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/run-check_title

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/run-check_dev

@fengou1 fengou1 mentioned this pull request Aug 23, 2021
Closed
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/review 3pointer

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/cc @3pointer @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from 3pointer August 23, 2021 09:49
@ti-chi-bot
Copy link
Member

@fengou1: GitHub didn't allow me to request PR reviews from the following users: YuJuncen.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @3pointer @YuJuncen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/cc @YuJuncen

@ti-chi-bot
Copy link
Member

@fengou1: GitHub didn't allow me to request PR reviews from the following users: YuJuncen.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @YuJuncen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YuJuncen
YuJuncen reviewed Aug 23, 2021
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/task/restore.go Show resolved Hide resolved
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 23, 2021

/cc @Leavrth

@ti-chi-bot ti-chi-bot requested a review from Leavrth August 23, 2021 09:52
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 24, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 24, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 25, 2021
@kennytm
Copy link
Contributor

kennytm commented Aug 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f5ed783

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@ti-chi-bot ti-chi-bot merged commit 07c3bf7 into pingcap:master Aug 25, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Sep 1, 2021

/label type/5.2-cherry-pick

@ti-chi-bot
Copy link
Member

@fengou1: The label(s) type/5.2-cherry-pick cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label type/5.2-cherry-pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fengou1
Copy link
Contributor Author

fengou1 commented Sep 1, 2021

/label needs-cherry-pick-5.2

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 1, 2021
@fengou1 @ti-srebot
cherry pick pingcap#27508 to release-5.2
9cd3436 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 1, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27727

joccau pushed a commit to joccau/tidb that referenced this pull request Sep 7, 2021
@fengou1
br, tidb: Add backup and restore size for TiDB SQL brie task (pingcap…
655c527 
…#27508)
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
br, tidb: Add backup and restore size for TiDB SQL brie task (#27508) (…
4f4f299 
…#27727)
@fengou1
Copy link
Contributor Author

fengou1 commented Oct 24, 2021

Existed Unit Test passed, the new UT need a lot of work and will create a new PR to UT.

@3pointer 3pointer mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BACKUP SQL Command returns size of 0
8 participants
@fengou1 @ti-chi-bot @sre-bot @kennytm @ti-srebot @YuJuncen @Leavrth @3pointer