-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update PD to fix the flag issue #27337
Conversation
Signed-off-by: you06 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1f4f9bb
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #27338 |
Signed-off-by: you06 [email protected]
What problem does this PR solve?
Issue Number: #27156
Problem Summary: now PD imports check package in some un-test packages, when TiDB imports them, TiDB will inherit some flags from check package. After this,
check.v
flag enables the unstable feature in production mode.What is changed and how it works?
This PR upgrade PD and import from PD no more introduce flags from check package.
What's Changed:
Update PD to the latest master, this removes flag pollution which will ship unstable features to the production environment.
How it Works:
Check List
Tests
Side effects
Documentation
Release note