Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked #27235

Merged
merged 17 commits into from
Aug 25, 2021
Merged

txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked #27235

merged 17 commits into from
Aug 25, 2021

Conversation

longfangsong
Copy link
Contributor

@longfangsong longfangsong commented Aug 16, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #27116

Problem Summary:

testTxnStateSerialSuite.TestRunning and testTxnStateSerialSuite.TestBlocked break sometimes.

What is changed and how it works?

  • Wait for all goroutings finished before return from the test
  • Use "pause" instead of "sleep" when possible
  • Sleep longer if we must
  • Use beforeLockKeys instead of mockStmtSlow(which will also block "commit")

Check List

Tests

  • Unit test

Side effects

NA

Documentation

NA

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 16, 2021
@ichn-hu ichn-hu mentioned this pull request Aug 16, 2021
Closed
@longfangsong longfangsong changed the title txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked [DNM] txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked Aug 20, 2021
@longfangsong longfangsong changed the title [DNM] txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked txn, session, test: Try to stabilize testTxnStateSerialSuite.TestRunning and TestBlocked Aug 20, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

PTAL @xhebox @lysu @tiancaiamao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6d6058d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2021
@longfangsong
Copy link
Contributor Author

Still cannot figure out why check_dev_2 failed.
Maybe related with #27410.

@longfangsong
Copy link
Contributor Author

longfangsong commented Aug 24, 2021 •
edited
Loading

Now blocked by #27328. 😭

@lysu
Copy link
Contributor

lysu commented Aug 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1022c4b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@ti-chi-bot
Copy link
Member

@longfangsong: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@longfangsong
Copy link
Contributor Author

/run-check_dev_2

2 similar comments
@tiancaiamao
Copy link
Contributor

/run-check_dev_2

@tiancaiamao
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 44f4e11 into pingcap:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test testTxnStateSerialSuite.TestBlocked
6 participants
@longfangsong @ti-chi-bot @bb7133 @tiancaiamao @lysu @tisonkun