Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Fix wrong way to check for overflow #27122

Merged
merged 2 commits into from
Aug 20, 2021
Merged

expression: Fix wrong way to check for overflow #27122

merged 2 commits into from
Aug 20, 2021

Conversation

UBarney
Copy link
Contributor

@UBarney UBarney commented Aug 11, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #26977

Tests

  • Unit test

Release note 

Fix wrong way to check for overflow

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 11, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ichn-hu ichn-hu mentioned this pull request Aug 11, 2021
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@UBarney UBarney changed the title Fix wrong way to check wether overflow expression: Fix wrong way to check whether overflow Aug 12, 2021
@UBarney UBarney changed the title expression: Fix wrong way to check whether overflow expression: Fix wrong way to check for overflow Aug 12, 2021
@UBarney
Copy link
Contributor Author

UBarney commented Aug 12, 2021

/run-check_title

@UBarney UBarney marked this pull request as ready for review August 12, 2021 07:56
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@wshwsh12
Copy link
Contributor

/cc @ichn-hu

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
@UBarney UBarney requested a review from wshwsh12 August 13, 2021 10:39
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 14a6f8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@ti-chi-bot ti-chi-bot merged commit 949dafb into pingcap:master Aug 20, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@UBarney @ti-srebot
cherry pick pingcap#27122 to release-4.0
c346b61 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27416

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@UBarney @ti-srebot
cherry pick pingcap#27122 to release-5.0
3335955 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27417

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@UBarney @ti-srebot
cherry pick pingcap#27122 to release-5.1
03c34c0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27418

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 20, 2021
@UBarney @ti-srebot
cherry pick pingcap#27122 to release-5.2
d205352 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 20, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27419

@UBarney UBarney deleted the fixOverflow branch August 20, 2021 10:00
@djshow832
Copy link
Contributor

Please add your release note.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 2, 2021
@UBarney
Copy link
Contributor Author

UBarney commented Sep 2, 2021

Please add your release note.

@djshow832 added in PR description

ti-chi-bot pushed a commit that referenced this pull request Sep 6, 2021
@ti-srebot
expression: Fix wrong way to check for overflow (#27122) (#27417)
daa260f
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
expression: Fix wrong way to check for overflow (#27122) (#27418)
8ca6e9e
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
expression: Fix wrong way to check for overflow (#27122) (#27419)
e3c8be8
ti-chi-bot pushed a commit that referenced this pull request Nov 19, 2021
@ti-srebot
expression: Fix wrong way to check for overflow (#27122) (#27416)
f0a1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss left review comments

@ichn-hu ichn-hu ichn-hu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigint unsigned range error when insert select
8 participants
@UBarney @ti-chi-bot @sre-bot @wshwsh12 @mjonss @ichn-hu @ti-srebot @djshow832