-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add physical table placement_policy in mysql schema #27054
Conversation
Signed-off-by: ailinkid <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This test is failing: [2021-08-10T05:12:36.524Z] infoschema_reader_test.go:917:
[2021-08-10T05:12:36.524Z] c.Assert(len(tk.MustQuery("select TABLE_NAME from information_schema.TABLE_STORAGE_STATS where TABLE_SCHEMA = 'mysql';").Rows()), Equals, 24)
[2021-08-10T05:12:36.524Z] ... obtained int = 25
[2021-08-10T05:12:36.524Z] ... expected int = 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, minor comment.
Co-authored-by: Morgan Tocker <[email protected]>
Signed-off-by: ailinkid <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 79a4ded
|
/run-all-tests |
/merge |
1 similar comment
/merge |
@AilinKid: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ailinkid [email protected]
What problem does this PR solve?
Issue Number: close part of #26580
Design table in mysql.* for persisting placement policies
What is changed and how it works?
What's Changed:
add physical table mysql.placement_policy to store the placement policy.
add this create table ddl both in the upgrade and bootstrap phase.
Check List
Tests
Release note