Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add physical table placement_policy in mysql schema #27054

Merged
merged 8 commits into from
Aug 13, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Aug 10, 2021

Signed-off-by: ailinkid [email protected]

What problem does this PR solve?

Issue Number: close part of #26580
Design table in mysql.* for persisting placement policies

What is changed and how it works?

What's Changed:
add physical table mysql.placement_policy to store the placement policy.
add this create table ddl both in the upgrade and bootstrap phase.

Check List

Tests

  • Unit test
  • Integration test

Release note

session: add physical table placement_policy in mysql schema.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@morgo morgo self-requested a review August 10, 2021 05:42
@morgo
Copy link
Contributor

morgo commented Aug 10, 2021

This test is failing:

[2021-08-10T05:12:36.524Z] infoschema_reader_test.go:917:
[2021-08-10T05:12:36.524Z]     c.Assert(len(tk.MustQuery("select TABLE_NAME from information_schema.TABLE_STORAGE_STATS where TABLE_SCHEMA = 'mysql';").Rows()), Equals, 24)
[2021-08-10T05:12:36.524Z] ... obtained int = 25
[2021-08-10T05:12:36.524Z] ... expected int = 24

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 10, 2021
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor comment.

session/bootstrap.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the sig/execution SIG execution label Aug 10, 2021
@morgo morgo self-requested a review August 12, 2021 03:00
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79a4ded

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/merge

1 similar comment
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants