Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use multi-layer projections for subquery selection (#8190) #26323

Closed
wants to merge 2 commits into from

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Jul 18, 2021

What problem does this PR solve?

Issue Number: #8190

Problem Summary: Use multi-layer projections to ensure the column in the subquery can find its reference to the outer alias column.

What is changed and how it works?

How it Works:

  • As for building select plan, use multi-layer projections for alias columns and subqueries columns if some selectFields are subqueries.

Check List

Tests

  • Unit test

Side effects

  • Performance regression: Consumes more CPU

Release note

  • Ensure the column in the subquery can find its reference to the outer alias column.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2021
@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Jul 18, 2021

/cc @winoros @qw4990 Hi, could you help me review this pr? Thanks :)

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Jul 18, 2021

@ti-chi-bot /run-all-tests

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Jul 18, 2021

@ti-chi-bot /run-all-tests

@ZiheLiu ZiheLiu closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants