inforschema, executor, util/kvcache, util/statement_summary : Add STATEMENTS_SUMMARY_EVICTED into information_schema #24513
+615
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance LRU cache, enable users access evicted key-value pair on Put() Signed-off-by: ClSlaid <[email protected]>
Release Note: enhanced LRU Cache some type fixes to cheat CI. Signed-off-by: ClSlaid <[email protected]>
typo fixes. Signed-off-by: ClSlaid <[email protected]>
enhance test on lru's Put() method. Signed-off-by: ClSlaid <[email protected]>
Add a function property in kvcache; Add a method to kvcache; Signed-off-by: ClSlaid <[email protected]>
Used Gofmt Signed-off-by: ClSlaid <[email protected]>
An initial commit, still cannot work properly. Signed-off-by: ClSlaid <[email protected]>
Catch up with PingCAP Signed-off-by: ClSlaid <[email protected]>
now we can see evicted count debug logging expressions not deleted... Signed-off-by: ClSlaid <[email protected]>
STATEMENTS_SUMMARY_EVICTED now able to use Test will be added in tomorrow. Signed-off-by: ClSlaid <[email protected]>
ti-chi-bot
added
the
size/XL
|
/cc @crazycs520 |
github-actions
bot
added
sig/execution
Purge logging code used for debugging. Signed-off-by: ClSlaid <[email protected]>
add test to evicted count, fix bugs in ssMap.other. Signed-off-by: ClSlaid <[email protected]>
crazycs520
reviewed
May 12, 2021
executor/infoschema_reader.go
Outdated
| @@ -2011,6 +2013,14 @@ func (e *memtableRetriever) setDataForClientErrorsSummary(ctx sessionctx.Context | |||
| return nil | |||
| } | |||
|
|
|||
| func (e *memtableRetriever) setDataForStmtSummaryEvicted(ctx sessionctx.Context, tableName string) error { | |||
There was a problem hiding this comment.
Look like this function is useless? just use e.rows = stmtsummary.StmtSummaryByDigestMap.ToEvictedCountDatum() in line#153?
There was a problem hiding this comment.
Good idea, I wasn't aware of it.
ti-chi-bot
added
the
status/can-merge
|
/run-check_dev_2 |
|
/merge |
1 similar comment
|
/merge |
|
/run-mybatis-test |
|
Should we cherry pick this into v4.0.x? |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 9, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0 in PR #25295 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 9, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #25296 |
crazycs520
added
needs-cherry-pick-release-5.1
and removed
needs-cherry-pick-4.0
needs-cherry-pick-release-5.0
labels
|
cherry pick to release-5.1 failed |
This was referenced Jun 21, 2021
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #23920
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
ssMap'sotherlist.Related changes
Check List
Tests
Side effects
Release note