Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Implements json_arrayagg function #23987

Closed
wants to merge 6 commits into from
Closed

executor: Implements json_arrayagg function #23987

wants to merge 6 commits into from

Conversation

blacktear23
Copy link
Contributor

@blacktear23 blacktear23 commented Apr 13, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: #7546, #14486

Problem Summary:

Implements json_arrayagg function.

What is changed and how it works?

What's Changed:

Add json_arrayagg function support.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test
  • Integration Test

Side effects

  • No

Release note

  • Add json_arrayagg function support.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@blacktear23 blacktear23 requested review from a team as code owners April 13, 2021 08:06
@blacktear23 blacktear23 requested review from qw4990 and lzmhhh123 and removed request for a team April 13, 2021 08:06
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2021
@blacktear23 blacktear23 changed the title [WIP] executor: Implements json_arrayagg function executor: Implements json_arrayagg function Apr 13, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021
@blacktear23 blacktear23 changed the title executor: Implements json_arrayagg function [WIP] executor: Implements json_arrayagg function Apr 13, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2021
@blacktear23 blacktear23 changed the title [WIP] executor: Implements json_arrayagg function executor: Implements json_arrayagg function Apr 13, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented May 19, 2021 •
edited
Loading

Hi, @blacktear23
Sorry for this late reply.
Would you mind helping to review #19957, since it's an earlier PR and got 1 LGTM already?

@blacktear23
Copy link
Contributor Author

@XuHuaiyu sure.

@qw4990 qw4990 requested review from wshwsh12 and a team and removed request for qw4990 June 21, 2021 03:38
@wshwsh12 wshwsh12 removed the request for review from lzmhhh123 June 24, 2021 09:29
@wshwsh12 wshwsh12 removed request for wshwsh12 and a team June 24, 2021 09:29
@blacktear23
Copy link
Contributor Author

As #19957 is merged, close this PR

@blacktear23 blacktear23 closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/expression size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blacktear23 @ti-chi-bot @XuHuaiyu