-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix logging format of prepared statements (#16062) #22984
executor: fix logging format of prepared statements (#16062) #22984
Conversation
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
1 similar comment
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
/run-all-test |
7f48866
to
9963ae4
Compare
a1935e4
to
c2c6963
Compare
c2c6963
to
bc1b564
Compare
All tests now pass. Could you take a look at the present pull request? @qw4990 |
} else { | ||
sql = FormatSQL(a.Text, sessVars.PreparedParams) | ||
} | ||
sql := FormatSQL(a.GetTextToLog()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid of that the new code broke the original semantic, which is introduced in #18578 by @crazycs520 , PTAL at this PR.
Please resolve conflicts at your convenience @nayuta-yanagisawa |
The CI fails continuously. I think that this is possibly fixed by #23967. |
/run-unit-test |
2 similar comments
/run-unit-test |
/run-unit-test |
/run-check_dev_2 |
/run-unit-test |
/run-integration-copr-test /run-sqllogic-test-2 |
What problem does this PR solve?
Issue Number: close #16062
Problem Summary: With a slow prepared statement, the slow query log records it in the form of
exec ...
rather than the underlying SQL with placeholders.What is changed and how it works?
What's Changed: Records original queries of prepared statements.
How it Works:
On master branch (53a68b5)
On PR branch
Related changes
N/A
Check List
Tests
Side effects
Release note