Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/preprocessor: disallow into-outfile clause in some place #21956

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: Part of #19097.

Problem Summary: For details, see #19097.

What is changed and how it works?

What's Changed:

  • Add an error ErrMisplacedIntoOutfile(3954).
  • Validate the 'into outfile' option. This clause is only allowed in the last select statement in union.

How it Works: Omitted.

Related changes

N/A

Check List

Tests

  • Unit test
  • Integration test

Side effects

N/A

Release note

  • No release note

@tangenta tangenta requested a review from a team as a code owner December 23, 2020 03:12
@tangenta tangenta requested review from SunRunAway and removed request for a team December 23, 2020 03:12
@ti-challenge-bot
Copy link

There is no reward for this challenge pull request, so you can request a reward from @qw4990.

Details

Tip : About reward you can refs to reward-command.

Warning: None

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@ti-chi-bot
Copy link
Member

@tangenta: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wshwsh12 wshwsh12 removed the request for review from a team June 18, 2021 07:03
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #21956 (24e1b14) into master (933e456) will increase coverage by 0.0022%.
Report is 9981 commits behind head on master.
The diff coverage is 94.4444%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #21956        +/-   ##
================================================
+ Coverage   76.8763%   76.8786%   +0.0022%     
================================================
  Files           572        572                
  Lines        144990     145026        +36     
================================================
+ Hits         111463     111494        +31     
- Misses        23484      23487         +3     
- Partials      10043      10045         +2     

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

ti-chi-bot bot commented Nov 18, 2024

@tangenta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 24e1b14 link true /test build
idc-jenkins-ci-tidb/unit-test 24e1b14 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 24e1b14 link true /test check-dev
pull-mysql-client-test 24e1b14 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/check_dev_2 24e1b14 link true /test check-dev2
pull-integration-ddl-test 24e1b14 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/mysql-test 24e1b14 link true /test mysql-test
pull-br-integration-test 24e1b14 link true /test pull-br-integration-test
pull-lightning-integration-test 24e1b14 link true /test pull-lightning-integration-test
pull-integration-e2e-test 24e1b14 link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/statistics needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution sig/planner SIG: Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants