Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, session, sessionctx: make last_plan_from_cache and last_plan_from_binding read-only #21953

Merged
merged 9 commits into from
Dec 24, 2020
Merged

executor, session, sessionctx: make last_plan_from_cache and last_plan_from_binding read-only #21953

merged 9 commits into from
Dec 24, 2020

Conversation

TszKitLo40
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #21943

Problem Summary:

What is changed and how it works?

What's Changed:
make last_plan_from_cache and last_plan_from_binding read-only
How it Works:
make last_plan_from_cache and last_plan_from_binding read-only

Check List

Tests

  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@TszKitLo40 TszKitLo40 requested a review from a team as a code owner December 23, 2020 02:52
@TszKitLo40 TszKitLo40 requested review from SunRunAway and removed request for a team December 23, 2020 02:52
@github-actions github-actions bot added the sig/execution SIG execution label Dec 23, 2020
@ichn-hu ichn-hu mentioned this pull request Dec 23, 2020
Closed
@morgo
Copy link
Contributor

morgo commented Dec 23, 2020

LGTM

@ti-srebot
Copy link
Contributor

@morgo, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack).

@morgo
Copy link
Contributor

morgo commented Dec 23, 2020

@TszKitLo40 please fix conflicts, thanks!

@TszKitLo40
Copy link
Contributor Author

@TszKitLo40 please fix conflicts, thanks!

OK, I have fixed it.

wjhuang2016
wjhuang2016 reviewed Dec 24, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
lzmhhh123
lzmhhh123 reviewed Dec 24, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 24, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 3879220 into pingcap:master Dec 24, 2020
Tjianke pushed a commit to Tjianke/tidb that referenced this pull request Dec 25, 2020
@TszKitLo40
executor, session, sessionctx: make last_plan_from_cache and last_pla…
787b255 
…n_from_binding read-only (pingcap#21953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variables last_plan_from_cache & last_plan_from_binding should be read-only
5 participants
@TszKitLo40 @morgo @ti-srebot @lzmhhh123 @wjhuang2016