Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Add column nullability checking before "refine args" #20044

Closed
wants to merge 3 commits into from

Conversation

youwithouto
Copy link

@youwithouto youwithouto commented Sep 16, 2020

What problem does this PR solve?

Issue Number: close #16788

This PR contains the same logic as PR 20040 which is a fix for Issue 16679

  • The same logic can fix both issues, while the two issues are "picked" by different persons.

Problem Summary:
When comparing a nullable integer column with a float, the output is not consistent with that of MySQL.

What is changed and how it works?

What's Changed:

Added column nullability checking

  • If the column is nullable, use raw args directly;
  • else, refine args

How it Works:

N/A

Related changes

N/A

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility
    For some of the statements, the corresponding execution plans are changed

Release note

  • No release note

@youwithouto youwithouto requested review from a team as code owners September 16, 2020 18:55
@youwithouto youwithouto requested review from wshwsh12 and lzmhhh123 and removed request for a team September 16, 2020 18:55
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 16, 2020

@ichn-hu ichn-hu mentioned this pull request Nov 3, 2020
@XuHuaiyu XuHuaiyu added sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Dec 16, 2020
@zz-jason
Copy link
Member

zz-jason commented Feb 9, 2021

I'm going to close this PR since it hasn't been updated for a long time. feel free to reopen if you want to continue with it. thanks for your contribution.

@zz-jason zz-jason closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. sig/planner SIG: Planner type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare NULL in int column with float got incorrect
5 participants