sessionctx: fix a bug where update stmt not considered when clipping negative num to 0 #19605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label type/bug-fix,needs-cherry-pick-3.0,needs-cherry-pick-4.0,needs-cherry-pick-3.1 |
|
/run-check_dev |
1 similar comment
|
/run-check_dev |
|
@XuHuaiyu PTAL~ |
|
/cc @qw4990 |
|
/run-all-tests |
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-integration-ddl-test |
|
@time-and-fate merge failed. |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #19772 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19773 |
ti-srebot
added a commit
that referenced
this pull request
Sep 5, 2020
…negative num to 0 (#19605) (#19773) Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added a commit
that referenced
this pull request
Sep 5, 2020
…negative num to 0 (#19605) (#19772) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #13150
Problem Summary:
Update stmt is not considered in
ShouldClipToZero(), which would cause the check is bypassed when trying to set an unsigned field to a negative number.Check List
Tests
Release note