executor: set the DDL query string instead of execute (#17407)
#17415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <[email protected]>
|
/run-all-tests |
sre-bot
added
sig/execution
zimulala
reviewed
May 26, 2020
executor/adapter.go
Outdated
| @@ -637,6 +637,11 @@ func (a *ExecStmt) buildExecutor() (Executor, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| <<<<<<< HEAD | |||
| ======= | |||
There was a problem hiding this comment.
@wjhuang2016
Please fix the conflict.
zimulala
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17407 to release-3.0
What problem does this PR solve?
Issue Number: close #17401
Problem Summary:
We didn't set the DDL query string properly. In an
EXECUTEstatement, we need to use the DDL query string we executing, not theexecutequery string.What is changed and how it works?
Proposal: xxx
If the executor is an
ExecuteExec, we set the query string to the real query string.Related changes
Check List
Tests
Side effects
Release note