Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: change dispatch error log level #16228

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Apr 9, 2020

What problem does this PR solve?

Problem Summary:
Currently, log level of dispatch error is WARN, it's better to change it to ERROR

What is changed and how it works?

Change log level of dispatch error from WARN to ERROR

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • None

Release note

@imtbkcat imtbkcat added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-3.0 labels Apr 9, 2020
@imtbkcat imtbkcat requested review from lysu and jackysp April 9, 2020 06:20
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #16228 into master will increase coverage by 0.5427%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #16228        +/-   ##
================================================
+ Coverage   80.3321%   80.8748%   +0.5427%     
================================================
  Files           506        506                
  Lines        135907     138812      +2905     
================================================
+ Hits         109177     112264      +3087     
+ Misses        18216      18057       -159     
+ Partials       8514       8491        -23     

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

Your auto merge job has been accepted, waiting for 16091

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 837b178 into pingcap:master Apr 9, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-3.0 in PR #16232

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-3.1 in PR #16233

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-4.0 in PR #16234

jackysp pushed a commit that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants