Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix create hash partition table makes tidb OOM (#16194) #16218

Merged
merged 4 commits into from
Apr 14, 2020
Merged

ddl: fix create hash partition table makes tidb OOM (#16194) #16218

merged 4 commits into from
Apr 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 9, 2020

cherry-pick #16194 to release-3.0

What problem does this PR solve?

Problem Summary:

CREATE TABLE employees (
    id INT NOT NULL,
    fname VARCHAR(30),
    lname VARCHAR(30),
    hired DATE NOT NULL DEFAULT '1970-01-01',
    separated DATE NOT NULL DEFAULT '9999-12-31',
    job_code INT,
    store_id INT
)

PARTITION BY HASH(store_id)
PARTITIONS 102400000000;

TiDB OOM

What is changed and how it works?

Check the partition count before create the slice.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 9, 2020
Merged
@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 9, 2020
@sre-bot sre-bot requested review from crazycs520 and jackysp April 9, 2020 02:35
crazycs520
crazycs520 reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict.

@tiancaiamao
Copy link
Contributor

Done @crazycs520 @jackysp

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

PTAL @jackysp @crazycs520

jackysp
jackysp reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520
crazycs520 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 14, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16310, 16008, 16009, 16175, 16232, 16233, 15738, 16132, 16133

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit e729528 into pingcap:release-3.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @tiancaiamao @jackysp @crazycs520