Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix error check in EvalSubquery (#11802) #11810

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 21, 2019

cherry-pick #11802 to release-3.0


Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

If there is an error when building executor in EvalSubquery, it is better to return the real error.

What is changed and how it works?

Return the real error.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. Change the order of prepare txn and compile in ExecutePreparedStmt.
  2. Run unit test case TestPrepared in seqtest suite.
  3. The test will not panic.

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 21, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit e044829 into pingcap:release-3.0 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants