planner: fix bug that window function do not check ignore nulls. #11554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
sig/planner
Codecov Report
@@ Coverage Diff @@
## master #11554 +/- ##
================================================
- Coverage 81.5161% 81.3014% -0.2147%
================================================
Files 426 425 -1
Lines 92681 91649 -1032
================================================
- Hits 75550 74512 -1038
- Misses 11756 11782 +26
+ Partials 5375 5355 -20 |
Codecov Report
@@ Coverage Diff @@
## master #11554 +/- ##
==========================================
Coverage ? 81.245%
==========================================
Files ? 426
Lines ? 91928
Branches ? 0
==========================================
Hits ? 74687
Misses ? 11879
Partials ? 5362 |
alivxxx
reviewed
Aug 1, 2019
|
/rebuild |
lzmhhh123
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-common-test tidb-test=pr/870 |
|
/run-integration-common-test tidb-test=pr/870 |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
jackysp
added
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-all-tests tidb-test=pr/870 |
|
/run-auto-merge |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #11593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10556
What is changed and how it works?
Add a simple judgment.
Check List
Tests
Code changes
Related changes