Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support cast as float #11519

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Jul 30, 2019

What problem does this PR solve?

Support cast(xxx as float).
Mysql support the parser in 8.0.17.
https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #11519 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11519   +/-   ##
===========================================
  Coverage   81.2074%   81.2074%           
===========================================
  Files           426        426           
  Lines         91983      91983           
===========================================
  Hits          74697      74697           
  Misses        11924      11924           
  Partials       5362       5362

@wshwsh12 wshwsh12 force-pushed the support_cast_as_float branch from e124471 to 5772db7 Compare July 31, 2019 09:26
@wshwsh12
Copy link
Contributor Author

/run-all-tests

@wshwsh12
Copy link
Contributor Author

/run-unit-test

@wshwsh12 wshwsh12 requested review from zz-jason and XuHuaiyu July 31, 2019 10:34
@qw4990
Copy link
Contributor

qw4990 commented Jul 31, 2019

/run-unit-test

2 similar comments
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2019

/run-unit-test

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Aug 1, 2019

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2019

/rebuild

@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2019

/run-unit-test

@wshwsh12 wshwsh12 force-pushed the support_cast_as_float branch from aa0dd37 to 9fccfd1 Compare August 1, 2019 04:47
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. and removed component/parser labels Aug 1, 2019
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2019

/run-all-test

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2019
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2019

/run-all-test

@qw4990 qw4990 merged commit 1c43f55 into pingcap:master Aug 1, 2019
@wshwsh12 wshwsh12 deleted the support_cast_as_float branch August 20, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants