-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, infoschema: fix display of default CURRENT_TIMESTAMP with decimal #11070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #11070 +/- ##
===========================================
Coverage ? 81.0658%
===========================================
Files ? 419
Lines ? 89848
Branches ? 0
===========================================
Hits ? 72836
Misses ? 11772
Partials ? 5240 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-integration-common-test |
What problem does this PR solve?
This PR fixes the following scenarios in which decimal fraction is missed for default
CURRENT_TIMESTAMP
in TiDB:SHOW CREATE TABLE
:SHOW (FULL) COLUMNS
:information_schema
:Notice that for all displays of the default values of time-related columns, the decimal fraction part is missed. This would cause some errors when users try to use those pieces of information, for example, create a table from
SHOW CREATE TABLE
:What is changed and how it works?
Simply adding the missed parts.
Check List
Tests
Code changes
Side effects
Related changes