planner: fix a corner case in column pruning rule (#10974) #11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bb7133 CI failed, PTAL |
bb7133
force-pushed
the
bb7133/cherry-pick_10974
branch
from
1d3bac6 to
92c4523
Compare
|
hi @eurekaka @zz-jason , CI failed because in v2.1 Now I added a panic to handle the possible error. Not sure if this is a good idea: https://github.com/pingcap/tidb/pull/11019/files#diff-e96c32593ee8e5ead5adbd45e60e61d9R106 |
|
/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
|
/run-integration-ddl-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
I think it's fine, because the panic should never be triggered for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #10974