expression: fix issue that TimeIsNull is not compatible with MySQL
#10957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/compatibility
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #10957 +/- ##
===============================================
- Coverage 81.222% 80.9774% -0.2446%
===============================================
Files 420 419 -1
Lines 90031 89373 -658
===============================================
- Hits 73125 72372 -753
- Misses 11675 11765 +90
- Partials 5231 5236 +5 |
breezewish
reviewed
Jun 27, 2019
expression/distsql_builtin.go
Outdated
| @@ -336,7 +336,12 @@ func getSignatureByPB(ctx sessionctx.Context, sigCode tipb.ScalarFuncSig, tp *ti | |||
| case tipb.ScalarFuncSig_RealIsNull: | |||
| f = &builtinRealIsNullSig{base} | |||
| case tipb.ScalarFuncSig_TimeIsNull: | |||
| f = &builtinTimeIsNullSig{base} | |||
| isNotNull := false | |||
| if len(expr.Children) > 0 && mysql.HasNotNullFlag(uint(expr.Children[0].FieldType.Flag)) { | |||
There was a problem hiding this comment.
No need for this check any more?
There was a problem hiding this comment.
Which check? len(expr.Children) > 0?.
alivxxx
reviewed
Jun 27, 2019
qw4990
force-pushed
the
fix-TimeIsNull
branch
6 times, most recently
from
aea4cee to
95b1dd9
Compare
|
@lamxTyler @breeswish PTAL~ |
qw4990
force-pushed
the
fix-TimeIsNull
branch
2 times, most recently
from
a2ea4af to
d1bc2c5
Compare
lonng
reviewed
Jul 5, 2019
| @@ -799,7 +799,12 @@ func (c *isNullFunctionClass) getFunction(ctx sessionctx.Context, args []Express | |||
| sig = &builtinRealIsNullSig{bf} | |||
| sig.setPbCode(tipb.ScalarFuncSig_RealIsNull) | |||
| case types.ETDatetime: | |||
| sig = &builtinTimeIsNullSig{bf} | |||
| isNotNull := false | |||
| _, isCol := args[0].(*Column) | |||
There was a problem hiding this comment.
Suggested change
| _, isCol := args[0].(*Column) | |
| col, isCol := args[0].(*Column) |
lonng
reviewed
Jul 5, 2019
| sig = &builtinTimeIsNullSig{bf} | ||
| isNotNull := false | ||
| _, isCol := args[0].(*Column) | ||
| if isCol && mysql.HasNotNullFlag(args[0].GetType().Flag) { |
There was a problem hiding this comment.
Suggested change
| if isCol && mysql.HasNotNullFlag(args[0].GetType().Flag) { | |
| if isCol && mysql.HasNotNullFlag(col.GetType().Flag) { |
There is no need to index the slice again.
|
@qw4990 You should override the |
|
The way in this PR to fix this issue is not appropriate, so I close it and fix it by another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9763.
What is changed and how it works?
Introduce a new variable
isNotNulltobuiltinTimeIsNullSigto judge if this column has aNotNullattribution and push it down toTiKV.Check List
Tests