-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support subquery in SHOW
statement
#10942
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10942 +/- ##
===========================================
Coverage 81.6603% 81.6603%
===========================================
Files 423 423
Lines 91152 91152
===========================================
Hits 74435 74435
Misses 11486 11486
Partials 5231 5231 |
/run-all-tests |
/run-unit-test |
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conflicts: planner/core/common_plans.go planner/core/find_best_task.go planner/core/initialize.go planner/core/planbuilder.go planner/core/resolve_indices.go
All tests passed, auto merged by Bot
What problem does this PR solve?
Before this PR:
What is changed and how it works?
The panic is caused by the fact that we didn't consider the possible subquery in the filter of show statement, if that happens, the rewritten expression would be nil, and hence panic would be raised in
ResolveIndices
.This PR solves this panic by:
Show
fromPlan
implementation toPhysicalPlan
implementation;Show
as a kind of data source, and build physical operators such as aggregation / join on top of it;After this PR:
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes