Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: improve unit tests code coverage #10792

Merged
merged 5 commits into from
Jun 29, 2019
Merged

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 13, 2019

What problem does this PR solve?

Move manager_test.go from tidb-test to the package of owner.
before:

ok  	github.com/pingcap/tidb/owner	0.232s	coverage: 19.4% of statements

after

ok  	github.com/pingcap/tidb/owner	6.579s	coverage: 67.9% of statements

What is changed and how it works?

Move manager_test.go from tidb-test to the package of owner.
And after the test, set the fault point value back to the original value.

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #10792 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #10792   +/-   ##
===========================================
  Coverage   80.9574%   80.9574%           
===========================================
  Files           418        418           
  Lines         89237      89237           
===========================================
  Hits          72244      72244           
  Misses        11762      11762           
  Partials       5231       5231

@zimulala
Copy link
Contributor Author

/run-all-tests

@zimulala
Copy link
Contributor Author

PTAL @jackysp @tiancaiamao @crazycs520

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 04fd418 into pingcap:master Jun 29, 2019
@zimulala zimulala deleted the owner-test branch July 2, 2019 06:44
zimulala added a commit to zimulala/tidb that referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants