-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticlient: set max send/recv msg size match tikv's config #10706
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10706 +/- ##
================================================
- Coverage 79.6786% 79.6434% -0.0352%
================================================
Files 414 414
Lines 87696 87731 +35
================================================
- Hits 69875 69872 -3
- Misses 12647 12684 +37
- Partials 5174 5175 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A better way is to use a common config on these values for tidb and tikv. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Now TiDB and TiKV use different max send/recv msg limit:
DB:
tidb/store/tikv/client.go
Line 56 in 9b4940b
KV:
https://github.com/tikv/tikv/blob/8dae71abe25cdcc511116f7d5b29312dffc2b152/src/server/server.rs#L108
What is changed and how it works?
set TiDB's send to 10M and recv to ulimited(MaxInt)
Check List
Tests
Code changes
Side effects
Related changes
This change is