Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support drop session binding #10287

Merged

Conversation

iamzhoug37
Copy link
Contributor

What problem does this PR solve?

associated iusse: #8935
feature: support add session binding
use case:
create table t(i int, s varchar(20))
create index index_t on t(i,s)
if we want to create a binding for current session, then we execute such SQL:
create session binding for select * from t using select * from t use index for join(index_t)
if we want to drop this session binding,we execute SQL:
drop session binding for select * from t

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes
N/A

Side effects
N/A

Related changes
N/A

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10287 into master will increase coverage by 0.0155%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10287        +/-   ##
================================================
+ Coverage   77.8178%   77.8333%   +0.0155%     
================================================
  Files           410        410                
  Lines         84365      84325        -40     
================================================
- Hits          65651      65633        -18     
+ Misses        13813      13801        -12     
+ Partials       4901       4891        -10

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10287 into master will increase coverage by 0.005%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master     #10287       +/-   ##
===============================================
+ Coverage   77.8256%   77.8306%   +0.005%     
===============================================
  Files           410        410               
  Lines         84715      84689       -26     
===============================================
- Hits          65930      65914       -16     
+ Misses        13856      13851        -5     
+ Partials       4929       4924        -5

@zz-jason zz-jason changed the title support drop session binding *: support drop session binding Apr 28, 2019
@zz-jason zz-jason added contribution This PR is from a community contributor. priority/P1 The issue has P1 priority. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Apr 28, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 28, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Apr 28, 2019

/run-all-tests

@alivxxx
Copy link
Contributor

alivxxx commented Apr 28, 2019

/run-common-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@alivxxx
Copy link
Contributor

alivxxx commented Apr 28, 2019

/run-mybatis-test

@alivxxx alivxxx merged commit 515b947 into pingcap:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. priority/P1 The issue has P1 priority. priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants