Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* : support show session binding #10285

Merged
merged 5 commits into from
Apr 28, 2019

Conversation

iamzhoug37
Copy link
Contributor

What problem does this PR solve?

associated iusse: #8935
feature: support add session binding
use case:
create table t(i int, s varchar(20))
create index index_t on t(i,s)
if we want to create a binding for current session, then we execute such SQL:
create session binding for select * from t using select * from t use index for join(index_t)
show session bindings:
image

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes
N/A

Side effects
N/A

Related changes
N/A

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10285 into master will increase coverage by 0.0188%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10285        +/-   ##
================================================
+ Coverage   77.8178%   77.8366%   +0.0188%     
================================================
  Files           410        410                
  Lines         84365      84324        -41     
================================================
- Hits          65651      65635        -16     
+ Misses        13813      13796        -17     
+ Partials       4901       4893         -8

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9630d57). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10285   +/-   ##
===========================================
  Coverage          ?   77.7416%           
===========================================
  Files             ?        410           
  Lines             ?      84539           
  Branches          ?          0           
===========================================
  Hits              ?      65722           
  Misses            ?      13907           
  Partials          ?       4910

@zz-jason zz-jason added the contribution This PR is from a community contributor. label Apr 28, 2019
@zz-jason zz-jason changed the title * : "show session binding" * : support show session binding Apr 28, 2019
@zz-jason zz-jason added priority/P1 The issue has P1 priority. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Apr 28, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Apr 28, 2019

/run-all-tests

@ngaut ngaut merged commit 168776d into pingcap:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. priority/P1 The issue has P1 priority. priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants