*: support "add session binding" #10238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
alivxxx
reviewed
Apr 23, 2019
bindinfo/handle.go
Outdated
| func NewBindHandle(parser *parser.Parser) *BindHandle { | ||
| handle := &BindHandle{} | ||
| handle.Parser = parser | ||
| handle.bindInfo.Value.Store(make(cache, 32)) |
There was a problem hiding this comment.
What about only allocate it on demand for session handle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
associated iusse: #8935
feature: support add session binding
use case:
create table t(i int, s varchar(20))create index index_t on t(i,s)if we want to create a binding for current session, then we execute such SQL:
create session binding for select * from t using select * from t use index for join(index_t)What is changed and how it works?
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A