Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support "show global bind" #10200

Merged

Conversation

iamzhoug37
Copy link
Contributor

What problem does this PR solve?

associated iusse: #8935
feature: support show global binding
use case:
create table t(i int, s varchar(20))
create index index_t on t(i,s)
create global binding for select * from t using select * from t use index for join(index_t)
if we want to show all global binding in the tidb, then we execute show global bindings
image

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes
N/A

Side effects
N/A

Related changes
N/A

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added type/new-feature contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Apr 19, 2019

/rebuild

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #10200 into master will increase coverage by 0.0273%.
The diff coverage is 92.3076%.

@@               Coverage Diff                @@
##             master     #10200        +/-   ##
================================================
+ Coverage   77.9142%   77.9416%   +0.0273%     
================================================
  Files           407        407                
  Lines         83049      83075        +26     
================================================
+ Hits          64707      64750        +43     
+ Misses        13536      13525        -11     
+ Partials       4806       4800         -6

@alivxxx
Copy link
Contributor

alivxxx commented Apr 19, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 5b13ff9 into pingcap:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants