*: support "drop global binding" #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10193 +/- ##
================================================
+ Coverage 77.9221% 77.9347% +0.0126%
================================================
Files 407 407
Lines 82911 83049 +138
================================================
+ Hits 64606 64724 +118
- Misses 13512 13524 +12
- Partials 4793 4801 +8 |
zz-jason
added
contribution
zz-jason
changed the title
|
/run-all-tests |
alivxxx
reviewed
Apr 19, 2019
…houg37/tidb into plan-management-drop-global-binding
alivxxx
reviewed
Apr 19, 2019
|
|
||
| for i := len(metas) - 1; i >= 0; i-- { | ||
| if meta.isSame(meta) { | ||
| metas = append(metas[:i], metas[i+1:]...) |
There was a problem hiding this comment.
If the slice reallocates, the metas will be different from c[hash]? And so with the removeStaleBindMetas.
There was a problem hiding this comment.
Never mind, remove won't reallocate.
alivxxx
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
associated iusse: #8935
feature: support drop global binding
use case:
create table t(i int, s varchar(20))create index index_t on t(i,s)create global binding for select * from t using select * from t use index for join(index_t)If we want to drop the global binding of
select * from t, we just executedrop global binding for select * from tWhat is changed and how it works?
Check List
Tests
Code changes
N/A
Related changes
N/A