session: adjust session log #10088
Merged
session: adjust session log #10088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove '[]' Signed-off-by: Keyi Xie <[email protected]>
xiekeyi98
added
type/enhancement
jackysp
approved these changes
Apr 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #10088 +/- ##
================================================
- Coverage 78.1195% 78.0692% -0.0503%
================================================
Files 405 405
Lines 82032 81999 -33
================================================
- Hits 64083 64016 -67
- Misses 13247 13275 +28
- Partials 4702 4708 +6 |
|
/run-all-tests |
|
/run-integration-common-test |
|
/run-common-test tidb-test=pr/779 |
|
/run-common-test tidb-test=pr/783 |
xiekeyi98
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove '[]'
Signed-off-by: Keyi Xie [email protected]
What problem does this PR solve?
Zap will automatically add the bracket.
Now, the bracket is a little redundancy.
And we should use
connas the abbreviation ofconnection, rather thancon.What is changed and how it works?
Change
contoconn&& remove the redundant bracket.Check List
Tests
Code changes
Side effects
Related changes
Before this PR merged:
This change is