Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: refactor slow log format and parse slow query log to SLOW_QUERY table. (#9290) #10060

Merged
merged 3 commits into from
Apr 9, 2019
Merged

*: refactor slow log format and parse slow query log to SLOW_QUERY table. (#9290) #10060

merged 3 commits into from
Apr 9, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #9290

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@crazycs520
Copy link
Contributor Author

@zz-jason @zimulala PTAL

@crazycs520 crazycs520 requested review from zz-jason and winkyao April 8, 2019 06:46
zz-jason
zz-jason reviewed Apr 8, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2019
zimulala
zimulala approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2019
@zz-jason zz-jason merged commit 011559c into pingcap:release-2.1 Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@zimulala zimulala zimulala approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazycs520 @zimulala @zz-jason