Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: support fast analyze in planner and executor's builder. #10040

Merged
merged 18 commits into from
Apr 10, 2019
Merged

planner, executor: support fast analyze in planner and executor's builder. #10040

merged 18 commits into from
Apr 10, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

A sub PR for fast analyze. Reference: #9973
Pre-requirement PR: #10039

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

  • none

@lzmhhh123 lzmhhh123 mentioned this pull request Apr 4, 2019
Closed
@lzmhhh123
Copy link
Contributor Author

PTAL @lamxTyler @zz-jason @erjiaqing , another unsubmitted PR "fast analyze execution" is blocked by this one.

alivxxx
alivxxx reviewed Apr 4, 2019
View reviewed changes
executor/analyze.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/common_plans.go Show resolved Hide resolved
planner/core/common_plans.go Show resolved Hide resolved
executor/builder.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited
Loading

Codecov Report

Merging #10040 into master will decrease coverage by 0.0687%.
The diff coverage is 17.2131%.

@@               Coverage Diff                @@
##             master     #10040        +/-   ##
================================================
- Coverage   78.1141%   78.0454%   -0.0688%     
================================================
  Files           405        405                
  Lines         82044      82156       +112     
================================================
+ Hits          64088      64119        +31     
- Misses        13248      13331        +83     
+ Partials       4708       4706         -2

alivxxx
alivxxx reviewed Apr 9, 2019
View reviewed changes
executor/builder.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
store/mockstore/mocktikv/rpc.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Apr 9, 2019
View reviewed changes
executor/builder.go Outdated Show resolved Hide resolved
@lzmhhh123 lzmhhh123 force-pushed the dev/fast_analyze_planner branch from 5969886 to afbbe21 Compare April 9, 2019 05:57
winoros
winoros reviewed Apr 9, 2019
View reviewed changes
executor/analyze.go Show resolved Hide resolved
executor/analyze.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Apr 9, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2019
@alivxxx alivxxx requested a review from winoros April 10, 2019 09:09
@lzmhhh123
Copy link
Contributor Author

PTAL. @winoros

winoros
winoros approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx
Copy link
Contributor

alivxxx commented Apr 10, 2019

/run-all-tests

@zz-jason zz-jason merged commit 5b469e0 into pingcap:master Apr 10, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2019
@lzmhhh123 lzmhhh123 deleted the dev/fast_analyze_planner branch July 24, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@winoros winoros winoros approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@zz-jason zz-jason Awaiting requested review from zz-jason

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @alivxxx @winoros @zz-jason